Skip to content

Stephan212 chart dynamic legend position #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2019

Conversation

StephanKuiper-Insight
Copy link
Owner

Description

Adds a new function to alter the chart's legend position.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

The position of the legend of charts was always fixed to the right. Adding in the option to set it dynamically via a new option under styles/chart
Add in the public functions to getStyle() to get and set the legend position
added legend position "tr" to description of public function setLegendPosition()
@StephanKuiper-Insight StephanKuiper-Insight merged commit 90a8900 into develop Aug 21, 2019
@StephanKuiper-Insight StephanKuiper-Insight deleted the Stephan212-ChartDynamicLegendPosition branch August 21, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant