Skip to content

Fix #83; standardize snippet formatting; remove duplicates #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2015
Merged

Fix #83; standardize snippet formatting; remove duplicates #90

merged 2 commits into from
Feb 26, 2015

Conversation

bcrotty
Copy link
Contributor

@bcrotty bcrotty commented Feb 18, 2015

No description provided.

vors
vors reviewed Feb 20, 2015
View reviewed changes
Snippets/(fun) define function.sublime-snippet
@@ -1,10 +1,10 @@
<!-- See http://www.sublimetext.com/docs/snippets for more information -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's changed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the file to standardize snippet names

@vors
Copy link
Member

vors commented Feb 20, 2015

I personally don't use snippets and don't have an opinion about them, so LGTM. @guillermooo ?

@guillermooo
Copy link
Member

Thanks for the PR!

Snippets are tricky. It's likely that some people will find them annoying. Personally, I like very short ones.

My suggestion:

  • include basic snippets (hard to define what's understood by 'basic'!)
  • have a separate repo for a more complete set of snippets

In any case, I think we should be using .sublime-snippets files (I think that's the name) as much as possible instead of .tmSnippets.

But if @bcrotty has simply cleaned up and unified the existing ones, let's merge this away for this time.

@vors
Copy link
Member

vors commented Feb 20, 2015

About $PSScriptRoot: I personally prefer defining it at the top level, if it's not defined. [PS v2]. Such snippet would encourage people produce less readable code. I would recommend remove it at all.

bcrotty
bcrotty reviewed Feb 20, 2015
View reviewed changes
Snippets/(mydocs) path to My Documents.sublime-snippet
<tabTrigger>mydocs</tabTrigger>
<!-- Optional: Scope the tab trigger will be active in -->
<scope>source.powershell</scope>
</snippet>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the file to standardize snippet names

vors added a commit that referenced this pull request Feb 26, 2015
@vors
Merge pull request #90 from bcrotty/snippets
b2202ae 
Fix #83; standardize snippet formatting; remove duplicates
@vors vors merged commit b2202ae into SublimeText:dev Feb 26, 2015
@bcrotty bcrotty mentioned this pull request Feb 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcrotty @vors @guillermooo