This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Add a workflow to validate the generated assets on CI. #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
This is a great addition to our CI workflow. Thanks for taking the time to implement this, @Lukas-Stuehrk.
I added a step to cache NPM dependencies, which appears to be working as expected. Please give that a quick look and then feel free to merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's rather easy to accidentally commit the wrong version of the generated CSS assets. Or to not commit the generated version and only the changed source. And it's not easy to validate if the generated CSS of a pull request correlates to the sources of the pull request.
This change introduces a new pipeline for CI. This pipeline builds the CSS from the sources and validates that the committed version of the generated CSS is identical to building it from source.