Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

build: bump SwiftSemantics to "main" #276

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Contributor

This allows the package to resolve with a newer toolchain. This is
required to get the Windows build enabled.

This allows the package to resolve with a newer toolchain.  This is
required to get the Windows build enabled.
@compnerd compnerd requested a review from mattt May 11, 2021 00:10
@compnerd
Copy link
Contributor Author

This would be really nice to get merged. Its unfortunate that the CI seems to have gotten stuck somewhere. I'm hoping to figure that out, but in the mean time, this change allows building the package locally on Windows at least.

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging a new version of SwiftSemantics and using that instead would be nicer, I guess. But overall this seems legit if temporary.

@mattt
Copy link
Contributor

mattt commented May 11, 2021

@compnerd The changes you need should be in SwiftSemantics 0.3.1. Can we use that tag instead of pinning to main?

@compnerd
Copy link
Contributor Author

@mattt - this is what I get if I try .upToNextMinor(from: "0.3.1"):

error: Dependencies could not be resolved because root depends on 'SwiftSemantics' 0.3.1..<0.4.0.
'SwiftSemantics' >= 0.3.1 cannot be used because package 'swiftsemantics' is required using a stable-version but 'swiftsemantics' depends on an unstable-version package 'swift-syntax' and no versions of 'SwiftSemantics' match the requirement 0.3.2..<0.4.0.

@compnerd
Copy link
Contributor Author

Closing in favour of #278 for signing requirements. Although that has a better commit message explaining the resolution failure so we have an alternative approach listed there.

@compnerd compnerd closed this May 12, 2021
@compnerd compnerd deleted the swift-semantics-main branch May 12, 2021 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants