Skip to content
This repository was archived by the owner on Mar 26, 2023. It is now read-only.

Issue/89 #317

Merged
merged 10 commits into from
Sep 28, 2017
Merged

Issue/89 #317

merged 10 commits into from
Sep 28, 2017

Conversation

RomanVolkov
Copy link
Member

@RomanVolkov RomanVolkov commented Sep 27, 2017

PR for #314
@SwiftWeekly/writers feel free to add your notes

@hal-codebot
Copy link

hal-codebot commented Sep 27, 2017

Proselint found issues

_drafts/2017-09-28-issue-89.md

Line Message Severity
7 More than 30 ppm of exclamations. Keep them under control. warning
31 Days of the week should be capitalized. 'Friday' is the preferred form. warning
37 Substitute 'damn' every time you're inclined to write 'very;' your editor will delete it and the writing will be just as it should be. warning

Spell Checker found issues

_drafts/2017-09-28-issue-89.md

Line Typo
7 Welcome to the 89 issue of the swift weekly new
17 * [SR-5996](https://bugs.swift.org/brows
18 * [SR-5995](https://bugs.swift.org/brows
19 * [SR-5983](https://bugs.swift.org/brows
20 * [SR-5982](https://bugs.swift.org/brows
20 gs.swift.org/browse/SR-5982): didSet causes unwanted calls to gett
20 ted calls to getter even when oldValue isn't used
26 in [Episode 30](https://spec.fm/podcasts/swi
26 /swift-unwrapped/87409) hosts Jese Squires and JP Simard with Mi
26 87409) hosts Jese Squires and JP Simard with Mike Ash discusse
26 09) hosts Jese Squires and JP Simard with Mike Ash discussed chang
26 ences implementation in Swift 4.
29 We can celebrate 10th LLVM [anniversary](https://tw
29 We can celebrate 10th LLVM [anniversary](https://twitter
29 es Swift exists. Keep it up, LL**VM.**
31 eferences implementation from 4th version of language.
35 [Ahmed Sulaiman](https://medium.com/
35 [Ahmed Sulaiman](https://medium.com/@ahmedsul
35 st: Debugging Swift code with LLDB](https://medium.com/flawless-
35 ldb-b30c5cf2fd49) about using lldb in general and some unpopular
37 02/status/911463433521860609) XCode simulator very slow performan
41 [Doug Gregor](https://github.com/DougGrego
41 the standard library part of [SE**-0157:** Recursive Protocol Constrain
42 its enclosing protocol, e.g., Sequence.SubSequence conforms to Sequence, Collect
42 equence conforms to Sequence, Collection.SubSequence conforms to Collection, and s
43 its enclosing protocol, e.g., Collection.Indices conforms to Collection, Bidir
43 dices conforms to Collection, BidirectionalCollection.Indices conforms to BidirectionalColl
43 ollection.Indices conforms to BidirectionalCollection, and so on
44 > - Make Numeric.Magnitude conform to Numeric
50 n situations with Objective-C inheritence from a typedef for a class/pr
50 bjective-C inheritence from a typedef for a class/protocol composit
52 [Philippe Hausler](https://github.com/p
52 Philippe Ha**usler**
52 ta slices. This change fixes SR**-5887,** [SR-5873](https://
52 ge fixes SR-5887, [SR-5873](https://bugs.swift.org/brows
52 wift.org/browse/SR-5873) and [SR-5810](https://bugs.swift.org/brows
55 [Doug Gregor](https://github.com/DougGrego
57 [Saleem Abdulrasool](https://github.c
57 Saleem Ab**dulrasool**
59 [Slava Pestov](https://github.com/sl
59 [Slava Pestov](https://github.com/slavapest
59 entation of a code completion fuzzer.
61 [Kacper Harasim](https://github.com/K
61 Kacper Ha**rasim**
61 .com/swiftlang/swift/pull/12128) [SR-5743](https://bugs.swift.org/brows
63 Michael Il**seman**
65 [Kacper Harasim](https://github.com/K
65 Kacper Ha**rasim**
77 roadmap for SwiftPM in Swift 5, and it's not clear yet wheth
82 a CoW should result in fillet mignon not ground chuck.

Generated by 🚫 Danger


### Finally

> TODO: something funny/fun. tweet, link, etc.
The problem [behind](https://twitter.com/xenadu02/status/911463433521860609) XCode simulator very slow performance is surprising.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"XCode" -> "Xcode".

Also, I'd move this into the "News and community" section since it's actual news, not just a humorous snippet that we usually feature in the "Finally" section.

Instead, I'd have this comment from swiftlang/swift#11939 in the "Finally" section:

tl;dr – Slicing a CoW should result in fillet mignon not ground chuck.

Copy link
Member Author

@RomanVolkov RomanVolkov Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't decided which section to use:) first was news, but I'm not sure that this news belongs to Swift ecosystem itself. So I moved it into finally. Will check tomorrow morning

@jessesquires
Copy link
Member

jessesquires commented Sep 27, 2017

Thanks @RomanVolkov ! 🎉 Awesome job 👍

Will review more later tonight.

@jessesquires jessesquires merged commit 11b7a0b into master Sep 28, 2017
@jessesquires jessesquires deleted the issue/89 branch September 28, 2017 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants