This repository was archived by the owner on Mar 26, 2023. It is now read-only.
Issue 94 #331
Merged
Issue 94 #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does Danger add anything besides noise? I feel it's more distracting than it is helpful. |
|
@modocache - it has helped before, but you're right -- mostly noise! we can disable 😄 it's supposed to work with markdown but it looks like it never really did (breaks on md links, etc) |
|
@jessesquires, what I saw, Danger alerts on many specific to development words and names. Is there any way to add them to ignore list? |
|
Yes, but I am afraid it is a continuous battle and would not be worth it. |
This was referenced Nov 3, 2017
Merged
BasThomas
reviewed
Nov 7, 2017
_drafts/2017-11-09-issue-94.md
Outdated
| disallowed by [SE-0054](https://github.com/apple/swift-evolution/blob/master/proposals/0054-abolish-iuo.md) | ||
| was considered valid in Swift 3 and 4. This is a "source-breaking" change for | ||
| codebases that used syntax that, while being technically invalid in Swift 3 and | ||
| 4, would not result in errors being emitted by the Swift compiler until now. |
There was a problem hiding this comment.
This looks 👍. It might not be source-breaking though if they go with Slava's suggestion here.
modocache
force-pushed
the
issue-94
branch
3 times, most recently
from
49d60a4 to
f4c997a
Compare
BasThomas
approved these changes
Nov 9, 2017
Not to be a stickler about this, but I do prefer a colon here, since it's followed by a list of things that happened in Swift development, and I think its usage here is grammatically correct. Let me know if the first sentence needs to be rewritten altogether, but I think if it's going to stay as-is then the colon isn't a bad choice here.
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.