Skip to content
This repository was archived by the owner on Mar 26, 2023. It is now read-only.

Issue 104 #371

Merged
merged 14 commits into from
Mar 8, 2018
Merged

Issue 104 #371

merged 14 commits into from
Mar 8, 2018

Conversation

BasThomas
Copy link
Contributor

@BasThomas BasThomas commented Mar 5, 2018

Closes #362

@hal-codebot
Copy link

hal-codebot commented Mar 5, 2018

1 Warning
⚠️ Looks like you’re publishing a new issue! 🎉
Don’t forget to:

  1. Review our style guide before merging
  2. After you merge, close the GitHub issue notes for this newsletter issue
  3. Open the next GitHub issue, add the correct labels, assign it to the next writer
  4. Run the new_draft.sh script and push the next draft
  5. <

Proselint found issues

_posts/2018-03-08-issue-104.md

Line Message Severity
7 More than 30 ppm of exclamations. Keep them under control. warning

Generated by 🚫 Danger

- [SR-7015](https://bugs.swift.org/browse/SR-7015) [Compiler] The CoreFoundation conditional downcast diagnostic is not as helpful as it should be
- [SR-6982](https://bugs.swift.org/browse/SR-6982) [Compiler] Improve internal compiler consistency
- [SR-6979](https://bugs.swift.org/browse/SR-6979) [Compiler] ThinToThickFunction derived pointers do not need to be retained/released
- [SR-6960](https://bugs.swift.org/browse/SR-6960) [Standard Library] Floating-point nextUp and nextDown are unnecessarily slow for concrete types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this addressed?

Copy link
Contributor Author

@BasThomas BasThomas Mar 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was addressed, but this seems like a different SR at least. A pull request that fixes SR-6919 is the one I could find. (mentioned in the last issue).

@jessesquires
Copy link
Member

Thanks for taking this @BasThomas ! 🙌

Will review more tomorrow.

Copy link
Member

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 👏

Some minor suggestions

---

> TODO: intro comments
With build time improvements in Swift 9.3, the 🏎 once again [proves its existence](https://twitter.com/cabel/status/793886373849608192).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe reword this? kind of confusing


> TODO

Greetings! Long time no see. Past two weeks pleased us with interesting updates about proposals, new Apple's NIO project and updates on Swift 4.2 release process. Enjoy the issue!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrite/reword this, too?

(Sounds like Roman's perspective, since he hadn't written an issue in awhile?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revisit, that’s why I put back the > TODO :)

- [SR-6979](https://bugs.swift.org/browse/SR-6979) [Compiler] `thin_to_thick_function` derived pointers do not need to be retained/released
- [SR-6960](https://bugs.swift.org/browse/SR-6960) [Standard Library] Floating-point `nextUp` and `nextDown` are unnecessarily slow for concrete types
- [SR-6889](https://bugs.swift.org/browse/SR-6889) [Compiler] Use `ArgMemOnly` for runtime functions
- [SR-6789](https://bugs.swift.org/browse/SR-6789) [Foundation] `IndexPath` needs benchmarks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's cut this down to only ~4 ?

Others can go in the next issue, if needed


### News and community

> TODO
Apple [released](https://download.developer.apple.com/Developer_Tools/Xcode_9.3_beta_4/Release_Notes_for_Xcode_9.3_beta_4.pdf) Xcode 9.3 beta 4. Erica Sadun [wrote](http://ericasadun.com/2018/03/05/new-to-swift-in-xcode-9-3-beta-4-se-0075-and-se-0190-allow-better-configuration-testing/) about some of the included Swift changes (`canImport` and `targetEnvironment`) within.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove "within"

At try! Swift, Norman Maurer introduced [SwiftNIO](https://github.com/apple/swift-nio), "a cross-platform asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients".
Interesting to note is that they are using [GitHub Issues](https://github.com/apple/swift-nio/issues); no JIRA!

Vapor then [integrated](https://twitter.com/codevapor/status/970012673852178432) with SwiftNIO mere days after the announcement. They were able to delete close to 15.000 lines of code! 😮
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

able to delete close to nearly


### Finally

> TODO: something funny/fun. tweet, link, etc.
Did you know that `enum` was once called [`oneof`](https://twitter.com/dgregor79/status/970857272724172800) — and [`union`](https://github.com/apple/swift/blob/master/CHANGELOG.md#2013-09-24)?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 😎

@@ -50,7 +50,17 @@ Marcin Krzyżanowski [wrote](https://pspdfkit.com/blog/2018/first-class-swift-ap

### Commits and pull requests

> TODO
[Reid Kleckner](https://github.com/rnk) pushed a [commit](https://github.com/apple/swift-clang/commit/334f080ab3c1bfbb13601a4f404b9c97e2294eb9) that fixes a variant of the [Spectre](https://spectreattack.com/spectre.pdf) vulnerability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'd include this. Isn't really Swift-specific and it's been widely covered in lots of programming publications. Besides I think Reid (although listed as a reviewer) isn't technically the author of that commit, that's Chandler Carruth, and Reid happened to re-apply the commit to swift-clang. Maybe I'm missing something though.

Copy link
Contributor

@tapthaker tapthaker Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpsim : My mistake, should have payed a closer attention to the commit. Will be deleting this point altogether.

@BasThomas BasThomas merged commit 42d5302 into master Mar 8, 2018
@BasThomas BasThomas deleted the issue-104 branch March 8, 2018 16:12
@jessesquires
Copy link
Member

🎉 💯 nice work @BasThomas !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

6 participants