Skip to content

Improve ParametricExpressions #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 24, 2024
Merged

Conversation

MilesCranmer
Copy link
Member

This also bumps to 0.18.0. It declares the Expression type as experimental.

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9638592821

Details

  • 36 of 44 (81.82%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 95.475%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ParametricExpression.jl 9 11 81.82%
src/Expression.jl 14 20 70.0%
Totals Coverage Status
Change from base Build 9635036647: -0.2%
Covered Lines: 2152
Relevant Lines: 2254

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9638614144

Details

  • 36 of 44 (81.82%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 95.475%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ParametricExpression.jl 9 11 81.82%
src/Expression.jl 14 20 70.0%
Totals Coverage Status
Change from base Build 9635036647: -0.2%
Covered Lines: 2152
Relevant Lines: 2254

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Benchmark Results

master dbb2866... master/dbb2866cd8ef6a...
eval/ComplexF32/evaluation 7.42 ± 0.45 ms 7.4 ± 0.45 ms 1
eval/ComplexF64/evaluation 9.65 ± 0.65 ms 9.69 ± 0.73 ms 0.997
eval/Float32/derivative 10.8 ± 1.7 ms 10.8 ± 1.6 ms 1
eval/Float32/derivative_turbo 10.8 ± 1.6 ms 10.8 ± 1.6 ms 1
eval/Float32/evaluation 2.73 ± 0.21 ms 2.73 ± 0.22 ms 1
eval/Float32/evaluation_bumper 0.534 ± 0.013 ms 0.535 ± 0.014 ms 0.998
eval/Float32/evaluation_turbo 0.708 ± 0.03 ms 0.699 ± 0.027 ms 1.01
eval/Float32/evaluation_turbo_bumper 0.533 ± 0.013 ms 0.529 ± 0.013 ms 1.01
eval/Float64/derivative 13.9 ± 0.61 ms 14.2 ± 0.58 ms 0.981
eval/Float64/derivative_turbo 13.9 ± 0.55 ms 14.2 ± 0.55 ms 0.98
eval/Float64/evaluation 2.92 ± 0.23 ms 2.9 ± 0.23 ms 1.01
eval/Float64/evaluation_bumper 1.21 ± 0.042 ms 1.21 ± 0.045 ms 0.998
eval/Float64/evaluation_turbo 1.18 ± 0.058 ms 1.18 ± 0.058 ms 0.996
eval/Float64/evaluation_turbo_bumper 1.21 ± 0.042 ms 1.21 ± 0.043 ms 0.995
utils/combine_operators/break_sharing 0.0409 ± 0.0013 ms 0.0414 ± 0.0013 ms 0.988
utils/convert/break_sharing 28 ± 0.94 μs 29.2 ± 0.9 μs 0.958
utils/convert/preserve_sharing 0.128 ± 0.0024 ms 0.127 ± 0.0025 ms 1.01
utils/copy/break_sharing 29 ± 0.9 μs 30.2 ± 0.88 μs 0.96
utils/copy/preserve_sharing 0.126 ± 0.0025 ms 0.129 ± 0.0026 ms 0.981
utils/count_constants/break_sharing 11.2 ± 0.17 μs 10.6 ± 0.15 μs 1.06
utils/count_constants/preserve_sharing 0.111 ± 0.0023 ms 0.111 ± 0.0022 ms 0.998
utils/count_depth/break_sharing 17.3 ± 0.34 μs 17.3 ± 0.38 μs 1
utils/count_nodes/break_sharing 9.8 ± 0.17 μs 9.93 ± 0.18 μs 0.986
utils/count_nodes/preserve_sharing 0.114 ± 0.0022 ms 0.115 ± 0.0023 ms 0.99
utils/get_set_constants!/break_sharing 0.121 ± 0.0041 ms 0.123 ± 0.0044 ms 0.988
utils/get_set_constants!/preserve_sharing 0.319 ± 0.0066 ms 0.32 ± 0.0064 ms 0.995
utils/has_constants/break_sharing 4.62 ± 0.21 μs 4.31 ± 0.21 μs 1.07
utils/has_operators/break_sharing 2.06 ± 0.018 μs 1.77 ± 0.018 μs 1.16
utils/hash/break_sharing 0.0327 ± 0.00052 ms 0.0325 ± 0.00045 ms 1.01
utils/hash/preserve_sharing 0.134 ± 0.0024 ms 0.135 ± 0.0025 ms 0.994
utils/index_constants/break_sharing 28.1 ± 0.63 μs 29 ± 0.68 μs 0.968
utils/index_constants/preserve_sharing 0.127 ± 0.0025 ms 0.127 ± 0.0025 ms 1
utils/is_constant/break_sharing 4.46 ± 0.21 μs 4.79 ± 0.21 μs 0.931
utils/simplify_tree/break_sharing 0.152 ± 0.015 ms 0.153 ± 0.015 ms 0.992
utils/simplify_tree/preserve_sharing 0.287 ± 0.017 ms 0.268 ± 0.017 ms 1.07
utils/string_tree/break_sharing 0.381 ± 0.011 ms 0.381 ± 0.01 ms 1
utils/string_tree/preserve_sharing 0.514 ± 0.013 ms 0.519 ± 0.014 ms 0.99
time_to_load 0.226 ± 0.00099 s 0.228 ± 0.0036 s 0.994

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9638804293

Details

  • 37 of 45 (82.22%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 95.475%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ParametricExpression.jl 9 11 81.82%
src/Expression.jl 15 21 71.43%
Totals Coverage Status
Change from base Build 9635036647: -0.2%
Covered Lines: 2152
Relevant Lines: 2254

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 139f99f into master Jun 24, 2024
18 checks passed
@MilesCranmer MilesCranmer deleted the parametric-expressions2 branch June 24, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants