Skip to content

Fix some method ambiguities in Expression #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

MilesCranmer
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9652164837

Details

  • 13 of 14 (92.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 95.438%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Expression.jl 9 10 90.0%
Totals Coverage Status
Change from base Build 9638984131: -0.04%
Covered Lines: 2155
Relevant Lines: 2258

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Benchmark Results

master db17350... master/db173503f164b4...
eval/ComplexF32/evaluation 7.38 ± 0.47 ms 7.43 ± 0.47 ms 0.993
eval/ComplexF64/evaluation 9.64 ± 0.67 ms 9.67 ± 0.72 ms 0.997
eval/Float32/derivative 10.8 ± 1.6 ms 11.2 ± 2.2 ms 0.968
eval/Float32/derivative_turbo 11 ± 1.9 ms 11 ± 1.8 ms 0.996
eval/Float32/evaluation 2.71 ± 0.21 ms 2.71 ± 0.23 ms 1
eval/Float32/evaluation_bumper 0.529 ± 0.013 ms 0.58 ± 0.014 ms 0.912
eval/Float32/evaluation_turbo 0.705 ± 0.033 ms 0.699 ± 0.032 ms 1.01
eval/Float32/evaluation_turbo_bumper 0.532 ± 0.014 ms 0.588 ± 0.014 ms 0.906
eval/Float64/derivative 13.9 ± 0.56 ms 14 ± 0.56 ms 0.996
eval/Float64/derivative_turbo 13.9 ± 0.5 ms 14.2 ± 0.91 ms 0.983
eval/Float64/evaluation 2.9 ± 0.24 ms 2.93 ± 0.24 ms 0.987
eval/Float64/evaluation_bumper 1.19 ± 0.043 ms 1.29 ± 0.045 ms 0.925
eval/Float64/evaluation_turbo 1.18 ± 0.059 ms 1.17 ± 0.058 ms 1.01
eval/Float64/evaluation_turbo_bumper 1.2 ± 0.044 ms 1.29 ± 0.045 ms 0.929
utils/combine_operators/break_sharing 0.0413 ± 0.0013 ms 0.0408 ± 0.0013 ms 1.01
utils/convert/break_sharing 28.4 ± 1.2 μs 28.1 ± 0.89 μs 1.01
utils/convert/preserve_sharing 0.128 ± 0.0038 ms 0.128 ± 0.0029 ms 0.995
utils/copy/break_sharing 29.6 ± 1.3 μs 29 ± 0.9 μs 1.02
utils/copy/preserve_sharing 0.128 ± 0.0042 ms 0.129 ± 0.0027 ms 0.996
utils/count_constants/break_sharing 10.1 ± 0.16 μs 11.3 ± 0.21 μs 0.896
utils/count_constants/preserve_sharing 0.113 ± 0.0034 ms 0.111 ± 0.0025 ms 1.02
utils/count_depth/break_sharing 17.4 ± 0.4 μs 17.4 ± 0.38 μs 1
utils/count_nodes/break_sharing 10.1 ± 0.15 μs 9.99 ± 0.18 μs 1.01
utils/count_nodes/preserve_sharing 0.115 ± 0.0027 ms 0.115 ± 0.0026 ms 1.01
utils/get_set_constants!/break_sharing 0.126 ± 0.0046 ms 0.125 ± 0.0044 ms 1.01
utils/get_set_constants!/preserve_sharing 0.327 ± 0.0094 ms 0.323 ± 0.0092 ms 1.01
utils/has_constants/break_sharing 4.44 ± 0.21 μs 4.32 ± 0.22 μs 1.03
utils/has_operators/break_sharing 1.93 ± 0.017 μs 1.77 ± 0.019 μs 1.09
utils/hash/break_sharing 0.0326 ± 0.00048 ms 0.0325 ± 0.00048 ms 1
utils/hash/preserve_sharing 0.137 ± 0.0034 ms 0.135 ± 0.0027 ms 1.02
utils/index_constants/break_sharing 27.9 ± 0.85 μs 27.7 ± 0.6 μs 1.01
utils/index_constants/preserve_sharing 0.127 ± 0.0024 ms 0.129 ± 0.0029 ms 0.985
utils/is_constant/break_sharing 4.37 ± 0.22 μs 4.41 ± 0.26 μs 0.991
utils/simplify_tree/break_sharing 0.155 ± 0.016 ms 0.155 ± 0.015 ms 0.998
utils/simplify_tree/preserve_sharing 0.273 ± 0.018 ms 0.279 ± 0.017 ms 0.978
utils/string_tree/break_sharing 0.392 ± 0.021 ms 0.376 ± 0.0096 ms 1.04
utils/string_tree/preserve_sharing 0.526 ± 0.015 ms 0.512 ± 0.011 ms 1.03
time_to_load 0.227 ± 0.0035 s 0.229 ± 0.0022 s 0.994

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9652296172

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 95.483%

Totals Coverage Status
Change from base Build 9638984131: 0.008%
Covered Lines: 2156
Relevant Lines: 2258

💛 - Coveralls

Copy link
Contributor

Pull Request Test Coverage Report for Build 9652338817

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 95.483%

Totals Coverage Status
Change from base Build 9638984131: 0.008%
Covered Lines: 2156
Relevant Lines: 2258

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9652338817

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 95.483%

Totals Coverage Status
Change from base Build 9638984131: 0.008%
Covered Lines: 2156
Relevant Lines: 2258

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 905ebc0 into master Jun 24, 2024
18 checks passed
@MilesCranmer MilesCranmer deleted the parametric-expressions2 branch June 24, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants