Skip to content

Fix additional ambiguous methods for Expression interface #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

MilesCranmer
Copy link
Member

No description provided.

@MilesCranmer MilesCranmer merged commit 9e95f05 into master Jun 24, 2024
17 checks passed
@MilesCranmer MilesCranmer deleted the parametric-expressions2 branch June 24, 2024 22:48
@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9653447356

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 95.444%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Simplify.jl 0 1 0.0%
Totals Coverage Status
Change from base Build 9652567211: -0.04%
Covered Lines: 2158
Relevant Lines: 2261

💛 - Coveralls

Copy link
Contributor

Benchmark Results

master 135b9db... master/135b9db23cf6e0...
eval/ComplexF32/evaluation 7.41 ± 0.49 ms 7.39 ± 0.48 ms 1
eval/ComplexF64/evaluation 9.67 ± 0.61 ms 9.71 ± 0.7 ms 0.996
eval/Float32/derivative 11.1 ± 2.1 ms 10.8 ± 1.7 ms 1.03
eval/Float32/derivative_turbo 11 ± 2 ms 10.8 ± 1.7 ms 1.02
eval/Float32/evaluation 2.74 ± 0.22 ms 2.72 ± 0.22 ms 1
eval/Float32/evaluation_bumper 0.551 ± 0.014 ms 0.531 ± 0.013 ms 1.04
eval/Float32/evaluation_turbo 0.71 ± 0.029 ms 0.698 ± 0.031 ms 1.02
eval/Float32/evaluation_turbo_bumper 0.534 ± 0.014 ms 0.531 ± 0.015 ms 1.01
eval/Float64/derivative 14.6 ± 0.62 ms 14 ± 0.61 ms 1.04
eval/Float64/derivative_turbo 14.5 ± 0.7 ms 14.1 ± 0.58 ms 1.03
eval/Float64/evaluation 2.98 ± 0.26 ms 2.91 ± 0.23 ms 1.02
eval/Float64/evaluation_bumper 1.2 ± 0.044 ms 1.2 ± 0.043 ms 1.01
eval/Float64/evaluation_turbo 1.23 ± 0.069 ms 1.18 ± 0.061 ms 1.04
eval/Float64/evaluation_turbo_bumper 1.21 ± 0.042 ms 1.19 ± 0.043 ms 1.01
utils/combine_operators/break_sharing 0.0412 ± 0.0013 ms 0.0415 ± 0.0013 ms 0.994
utils/convert/break_sharing 28.5 ± 1 μs 28.5 ± 0.91 μs 0.999
utils/convert/preserve_sharing 0.13 ± 0.003 ms 0.128 ± 0.003 ms 1.01
utils/copy/break_sharing 29.2 ± 0.99 μs 29.2 ± 0.92 μs 1
utils/copy/preserve_sharing 0.132 ± 0.0032 ms 0.128 ± 0.0029 ms 1.03
utils/count_constants/break_sharing 11 ± 0.19 μs 10.4 ± 0.17 μs 1.06
utils/count_constants/preserve_sharing 0.112 ± 0.0027 ms 0.112 ± 0.0025 ms 1
utils/count_depth/break_sharing 16.9 ± 0.38 μs 17 ± 0.41 μs 0.996
utils/count_nodes/break_sharing 9.68 ± 0.22 μs 9.82 ± 0.17 μs 0.985
utils/count_nodes/preserve_sharing 0.115 ± 0.0028 ms 0.114 ± 0.0024 ms 1.01
utils/get_set_constants!/break_sharing 0.124 ± 0.0042 ms 0.122 ± 0.0043 ms 1.02
utils/get_set_constants!/preserve_sharing 0.321 ± 0.0071 ms 0.318 ± 0.0083 ms 1.01
utils/has_constants/break_sharing 4.57 ± 0.22 μs 4.65 ± 0.22 μs 0.984
utils/has_operators/break_sharing 2.09 ± 0.024 μs 2.09 ± 0.02 μs 1
utils/hash/break_sharing 0.0326 ± 0.00048 ms 0.0329 ± 0.0005 ms 0.991
utils/hash/preserve_sharing 0.138 ± 0.0027 ms 0.135 ± 0.0027 ms 1.02
utils/index_constants/break_sharing 27.6 ± 0.83 μs 27.3 ± 0.72 μs 1.01
utils/index_constants/preserve_sharing 0.13 ± 0.003 ms 0.129 ± 0.0029 ms 1.01
utils/is_constant/break_sharing 4.52 ± 0.22 μs 4.51 ± 0.22 μs 1
utils/simplify_tree/break_sharing 0.154 ± 0.015 ms 0.155 ± 0.015 ms 0.995
utils/simplify_tree/preserve_sharing 0.285 ± 0.018 ms 0.293 ± 0.018 ms 0.974
utils/string_tree/break_sharing 0.398 ± 0.022 ms 0.393 ± 0.013 ms 1.01
utils/string_tree/preserve_sharing 0.542 ± 0.02 ms 0.538 ± 0.017 ms 1.01
time_to_load 0.228 ± 0.002 s 0.227 ± 0.0022 s 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants