-
Notifications
You must be signed in to change notification settings - Fork 16
Faster ChainRules implementation #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results
|
Blocked by aviatesk/JET.jl#642 |
Pull Request Test Coverage Report for Build 9737805856Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9737908889Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
eval_grad_tree_array
to have a:both
mode that computes gradients w.r.t both constants and features at the same time.Also declares various functions to be non differentiable, which weirdly makes the differentiation like 10x faster.
It looks like the problem is from runtime dispatch on
Zygote.gradient(f, expression)
even though the final return type and value is correct. I wonder if it has to do with it having the output containing a recursive type (theNode
). Worth investing further or maybe raising an issue on Zygote.jl or ChainRulesCore.jl.