Skip to content

Add more prefixes #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 3, 2023
Merged

Add more prefixes #100

merged 4 commits into from
Dec 3, 2023

Conversation

MilesCranmer
Copy link
Member

Apparently the common prefixes are not too uncommon, so we can add them:

  • pmol, nmol, μmol (/umol)
  • pV, nV, μV (/uV), mV
  • nΩ, μΩ (/uΩ)
  • μL (/uL)

@SymbolicML SymbolicML deleted a comment from sweep-ai bot Dec 3, 2023
Copy link
Contributor

github-actions bot commented Dec 3, 2023

Benchmark Results

main c260429... t[main]/t[c260429...]
Quantity/creation/Quantity(x) 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1
Quantity/creation/Quantity(x, length=y) 3.1 ± 0.24 ns 3.11 ± 0.01 ns 0.996
Quantity/with_numbers/*real 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1
Quantity/with_numbers/^int 8.28 ± 2.5 ns 8.36 ± 2.5 ns 0.99
Quantity/with_numbers/^int * real 8.37 ± 2.5 ns 8.36 ± 2.5 ns 1
Quantity/with_quantity/+y 5.27 ± 0.01 ns 5.27 ± 0.01 ns 1
Quantity/with_quantity//y 3.11 ± 0.001 ns 3.11 ± 0.001 ns 1
Quantity/with_self/dimension 1.55 ± 0.01 ns 1.55 ± 0.01 ns 1
Quantity/with_self/inv 3.11 ± 0.001 ns 3.11 ± 0.01 ns 1
Quantity/with_self/ustrip 1.55 ± 0.01 ns 1.55 ± 0.01 ns 1
QuantityArray/broadcasting/multi_array_of_quantities 0.149 ± 0.14 ms 0.147 ± 0.0051 ms 1.02
QuantityArray/broadcasting/multi_normal_array 0.0498 ± 0.00022 ms 0.0589 ± 0.0079 ms 0.844
QuantityArray/broadcasting/multi_quantity_array 0.158 ± 0.00095 ms 0.158 ± 0.00082 ms 1
QuantityArray/broadcasting/x^2_array_of_quantities 25.1 ± 2.2 μs 24.6 ± 1.6 μs 1.02
QuantityArray/broadcasting/x^2_normal_array 4.05 ± 1.1 μs 4.16 ± 0.99 μs 0.973
QuantityArray/broadcasting/x^2_quantity_array 6.88 ± 0.19 μs 6.91 ± 0.21 μs 0.996
QuantityArray/broadcasting/x^4_array_of_quantities 0.0783 ± 0.00042 ms 0.0783 ± 0.00037 ms 1
QuantityArray/broadcasting/x^4_normal_array 0.0497 ± 0.00014 ms 0.0497 ± 0.00017 ms 1
QuantityArray/broadcasting/x^4_quantity_array 0.0591 ± 0.00016 ms 0.0592 ± 0.00019 ms 1
time_to_load 0.239 ± 0.0016 s 0.239 ± 0.00088 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer merged commit 745681d into main Dec 3, 2023
@MilesCranmer MilesCranmer deleted the unitful-compatibility branch December 3, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant