Ensure user-defined mutable version of dimensions always copied #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the default
Dimensions
is immutable, and the mutableSymbolicDimensions
(which uses a sparse array) should always create a copy anyways, the user could declare aAbstractDimensions
that is mutable and does not copy itself.Therefore this PR implements
copy
for a variety of operations on bothQuantityArray
andAbstractQuantity
.todo: