-
Notifications
You must be signed in to change notification settings - Fork 25
Fix numeric promotion rules #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the biggest fan of having to manually list the numeric types here, as it's not extensible for other packages defining numeric-like types.
I think it deserves a bit of thought whether there's a slicker way to do this that still doesn't run into the issue you mentioned with other number packages. But I can't think about this at least for the next day or two, so if you'd like to merge and improve this looks good to me:)
Sounds good. Yeah I just have no idea how to figure out the ambiguity for things like julia> using DynamicQuantities, Measurements
julia> [0.3±0.1, 3u"km/s"]
2-element Vector{Number}:
0.3 ± 0.1
3000.0 m s⁻¹ i.e., should this be a And for extensibility, users can always define their own |
@gaurav-arya this should address your comment in #78.
Now you can do
and it will be an array of
Quantity{Float64,...}
.