Skip to content

More unitful compatibility #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 3, 2023
Merged

More unitful compatibility #98

merged 4 commits into from
Dec 3, 2023

Conversation

MilesCranmer
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

Benchmark Results

main a6df107... t[main]/t[a6df107...]
Quantity/creation/Quantity(x) 2.79 ± 0.01 ns 3.1 ± 0.01 ns 0.9
Quantity/creation/Quantity(x, length=y) 3.11 ± 0.92 ns 3.11 ± 0.01 ns 1
Quantity/with_numbers/*real 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1
Quantity/with_numbers/^int 8.05 ± 2.2 ns 8.37 ± 2.2 ns 0.963
Quantity/with_numbers/^int * real 8.05 ± 2.2 ns 8.37 ± 2.2 ns 0.963
Quantity/with_quantity/+y 5.27 ± 0.01 ns 5.27 ± 0.01 ns 1
Quantity/with_quantity//y 3.41 ± 0.01 ns 3.42 ± 0.011 ns 0.997
Quantity/with_self/dimension 1.55 ± 0.01 ns 1.55 ± 0.01 ns 1
Quantity/with_self/inv 3.11 ± 0.01 ns 3.11 ± 0.01 ns 1
Quantity/with_self/ustrip 1.56 ± 0.01 ns 1.59 ± 0.01 ns 0.981
QuantityArray/broadcasting/multi_array_of_quantities 0.147 ± 0.14 ms 0.158 ± 0.14 ms 0.932
QuantityArray/broadcasting/multi_normal_array 0.0529 ± 0.0003 ms 0.0478 ± 0.00022 ms 1.11
QuantityArray/broadcasting/multi_quantity_array 0.158 ± 0.00081 ms 0.159 ± 0.00075 ms 0.999
QuantityArray/broadcasting/x^2_array_of_quantities 24 ± 2.1 μs 25 ± 2.4 μs 0.958
QuantityArray/broadcasting/x^2_normal_array 4.24 ± 1.1 μs 4.2 ± 0.9 μs 1.01
QuantityArray/broadcasting/x^2_quantity_array 6.15 ± 0.31 μs 5.98 ± 0.27 μs 1.03
QuantityArray/broadcasting/x^4_array_of_quantities 0.0785 ± 0.00036 ms 0.0817 ± 0.00072 ms 0.961
QuantityArray/broadcasting/x^4_normal_array 0.059 ± 0.00018 ms 0.0467 ± 0.0002 ms 1.26
QuantityArray/broadcasting/x^4_quantity_array 0.0592 ± 0.00023 ms 0.0592 ± 0.00028 ms 1
time_to_load 0.24 ± 0.0034 s 0.248 ± 0.0013 s 0.966

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@SymbolicML SymbolicML deleted a comment from sweep-ai bot Dec 3, 2023
@MilesCranmer MilesCranmer force-pushed the unitful-compatibility branch from 033ea36 to 0d3e75d Compare December 3, 2023 11:38
@MilesCranmer MilesCranmer merged commit 54158ca into main Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant