Skip to content

More units #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2023
Merged

More units #99

merged 2 commits into from
Dec 3, 2023

Conversation

Mo-Gul
Copy link
Contributor

@Mo-Gul Mo-Gul commented Dec 3, 2023

I'd argue that mbar is also a quite common unit. At least much more than dL. And because I also think that cL is at least as common as dL that should be added as well.
Feel free to cherry-pick.

@SymbolicML SymbolicML deleted a comment from sweep-ai bot Dec 3, 2023
Copy link
Contributor

github-actions bot commented Dec 3, 2023

Benchmark Results

main df86e36... t[main]/t[df86e36...]
Quantity/creation/Quantity(x) 3.1 ± 0.01 ns 2.79 ± 0.01 ns 1.11
Quantity/creation/Quantity(x, length=y) 3.11 ± 0.01 ns 3.11 ± 0.01 ns 1
Quantity/with_numbers/*real 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1
Quantity/with_numbers/^int 8.37 ± 2.5 ns 8.05 ± 2.2 ns 1.04
Quantity/with_numbers/^int * real 8.37 ± 2.5 ns 8.05 ± 2.2 ns 1.04
Quantity/with_quantity/+y 5.27 ± 0.01 ns 5.27 ± 0.01 ns 1
Quantity/with_quantity//y 3.11 ± 0.01 ns 3.41 ± 0.01 ns 0.912
Quantity/with_self/dimension 1.56 ± 0.01 ns 1.55 ± 0.01 ns 1.01
Quantity/with_self/inv 3.11 ± 0.001 ns 3.11 ± 0.01 ns 1
Quantity/with_self/ustrip 1.55 ± 0.01 ns 1.55 ± 0.01 ns 1
QuantityArray/broadcasting/multi_array_of_quantities 0.15 ± 0.013 ms 0.147 ± 0.14 ms 1.02
QuantityArray/broadcasting/multi_normal_array 0.0498 ± 0.00031 ms 0.053 ± 0.0092 ms 0.941
QuantityArray/broadcasting/multi_quantity_array 0.158 ± 0.0009 ms 0.158 ± 0.00059 ms 1
QuantityArray/broadcasting/x^2_array_of_quantities 25 ± 1.9 μs 25.1 ± 1.8 μs 0.997
QuantityArray/broadcasting/x^2_normal_array 4.29 ± 0.99 μs 4.31 ± 1 μs 0.995
QuantityArray/broadcasting/x^2_quantity_array 6.92 ± 0.23 μs 6.12 ± 0.46 μs 1.13
QuantityArray/broadcasting/x^4_array_of_quantities 0.0784 ± 0.00046 ms 0.0784 ± 0.00073 ms 1
QuantityArray/broadcasting/x^4_normal_array 0.0497 ± 0.00016 ms 0.0497 ± 0.0002 ms 1
QuantityArray/broadcasting/x^4_quantity_array 0.0592 ± 0.00017 ms 0.0594 ± 0.0061 ms 0.997
time_to_load 0.241 ± 0.0066 s 0.243 ± 0.0056 s 0.989

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer
Copy link
Member

Thanks!

@MilesCranmer MilesCranmer merged commit 6d53d77 into SymbolicML:main Dec 3, 2023
@Mo-Gul
Copy link
Contributor Author

Mo-Gul commented Dec 3, 2023

I have to thank (all of) you for your awesome work !!!

@Mo-Gul Mo-Gul deleted the more_units branch December 3, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants