Update stream-everything.md #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,7 +96,7 @@ In `symfony/ux-turbo` 2.1 and higher, this code has changed: | |||
|
|
|||
| ```php | |||
| if (TurboBundle::STREAM_FORMAT === $request->getPreferredFormat()) { | |||
| $request->setFormat(TurboBundle::STREAM_FORMAT); | |||
| $request->setRequestFormat(TurboBundle::STREAM_FORMAT); | |||
There was a problem hiding this comment.
Hm, I'm not sure about this change. I suppose the example was taken from the official docs: https://symfony.com/bundles/ux-turbo/current/index.html#forms - there we have $request->setFormat(TurboBundle::STREAM_FORMAT);. If it does not work - then it should be fixed upstream in the Symfony docs as well
There was a problem hiding this comment.
Its not working, there are several issues about it on symfony github, as well as pull requests.
/**
* Associates a format with mime types.
* /
public function setFormat(?string $format, $mimeTypes)
/**
* Sets the request format.
*/
public function setRequestFormat(?string $format)
There was a problem hiding this comment.
Yeah, I see it, you're right! And it seems it was already fixed upstream in the docs I referenced above 👍
|
Thank you for this fix! I'm merging this now, later the video note also will be tweaked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example is not functional.