883478 How to change cursor and add tool-tip when mouse over the uri annotation in PdfViewer #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annotation in PdfViewer
RajaVigneshB
requested changes
Jul 30, 2024
…annotation in PdfViewer
RajaVigneshB
approved these changes
Jul 30, 2024
Deepak1799
requested changes
Jul 30, 2024
| docView.Load(stream); | ||
| annotationPageIndex = 0; | ||
| annotationBounds = uriAnnotation.Bounds; | ||
| //annotationBounds = convertor.ConvertToPixels(annotationBounds, PdfGraphicsUnit.Point); |
There was a problem hiding this comment.
- Remove the commented lines
- Remove unwanted namespaces
- Add comments wherever possible as it is a public repo
There was a problem hiding this comment.
I have addressed the provided feedbacks.
…annotation in PdfViewer
Deepak1799
requested changes
Jul 30, 2024
| @@ -0,0 +1,9 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <packages> | |||
| <package id="Syncfusion.Compression.Base" version="26.2.5" targetFramework="net48" /> | |||
There was a problem hiding this comment.
Why we specifically mention the version in the package? Can this be "*"?
There was a problem hiding this comment.
I have addressed the provided feedback
…annotation in PdfViewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to change cursor and add tool-tip when mouse over the uri annotation in PdfViewer