Upgrade to version 0.3.4 #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import homeRouter from './home-router' | ||
|
|
||
| const routes = [ | ||
| { | ||
| path: '/', | ||
| name: 'Home', | ||
| redirect: '/about', | ||
| component: Home, | ||
| component: () => import('@/views/home/Home'), |
There was a problem hiding this comment.
这个块不拆分, 少一次请求, 其实也没啥问题
| @@ -1,5 +1,6 @@ | |||
| import Vue from 'vue' | |||
| import Vuex from 'vuex' | |||
| import createLogger from 'vuex/dist/logger' | |||
| @@ -81,7 +81,7 @@ export default { | |||
| this.loading = false | |||
| console.log(e) | |||
| } | |||
| if (res.code < window.SUCCESS_CODE) { | |||
| if (res.code < window.MAX_SUCCESS_CODE) { | |||
There was a problem hiding this comment.
这个写法感觉有点问题, 既然是成功失败, 判断写在通用的组件里, 应用的时候使用 try catch是不是更好一些. 也不需要在window上挂全局变量
There was a problem hiding this comment.
这个写法感觉有点问题, 既然是成功失败, 判断写在通用的组件里, 应用的时候使用 try catch是不是更好一些. 也不需要在window上挂全局变量
写在通用组件里，每次使用的时候还要引入，除非挂载在 vm 实例上
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.