Merge from symfony-docs #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 3.4 branch. Discussion ---------- Fix missing `;` in the samples Fix the sample PHP code so the syntax is valid :) Commits ------- da8f6ea Fix missing `;` in the samples
This PR was merged into the 3.4 branch. Discussion ---------- Fix error on @MaxDepth property Change property annotation according to documentation <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 2ce9d9c Fix error on @MaxDepth property for annotation, yaml and xml. Change property according to documentation
This PR was merged into the 2.7 branch. Discussion ---------- Removed the term "simple" from creating a new page Something that's simple for me, might not be simple for a developer who is new to Symfony. I think this is a friendlier approach to the process of creating a new page. I haven't checked the other docs as I quickly pressed edit when I noticed this. Commits ------- 292d6ea Removed the term "simple" from creating a new page
* 2.7: Use gender-neutral language in the main Serializer article [#9497] fix typo Removed the term "simple" from creating a new page Update datetime.rst components/phpunit_bridge.rst Add best practice note about version Use is_numeric() [Console] Fix SymfonyStyle::ask usage Update BC policy to tell about adding/removing return types
* 2.8: Use gender-neutral language in the main Serializer article Removed the term "simple" from creating a new page Update datetime.rst components/phpunit_bridge.rst Add best practice note about version Use is_numeric() drop deprecated config value [Console] Fix SymfonyStyle::ask usage Update BC policy to tell about adding/removing return types
* 3.4: (24 commits) Added a caution note about env vars and the profiler Use gender-neutral language in the main Serializer article Fix error on @MaxDepth property for annotation, yaml and xml. Change property according to documentation Link to the asset component documentation New section about JSON file manifest strategy Removed the term "simple" from creating a new page Update datetime.rst components/phpunit_bridge.rst Add best practice note about version Fixed formatting Autowiring - Rephrase aliasing when multiple classes implement same interface Use is_numeric() ...
* 4.0: (27 commits) Added a caution note about env vars and the profiler Use gender-neutral language in the main Serializer article Fix error on @MaxDepth property for annotation, yaml and xml. Change property according to documentation Link to the asset component documentation New section about JSON file manifest strategy Removed the term "simple" from creating a new page classname typo fixed Update datetime.rst components/phpunit_bridge.rst Add best practice note about version Fixed formatting Autowiring - Rephrase aliasing when multiple classes implement same interface ...
This PR was merged into the 4.0 branch. Discussion ---------- Grammar fix - Change "you're" to "your" <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- e4f50dc Grammar fix - Change "you're" to "your"
* 3.4: Fix issue #9798
* 4.0: Grammar fix - Change "you're" to "your" Fix issue #9798
This PR was submitted for the master branch but it was merged into the 4.0 branch instead (closes #9746). Discussion ---------- Add service binding to argument name example I just learned this is possible - thought it should be documented. Commits ------- 6b1f9c1 add service binding to argument name example
This PR was submitted for the 4.0 branch but it was squashed and merged into the 3.4 branch instead (closes #9695). Discussion ---------- Update 3.3-di-changes.rst Related to #9676 (review) Commits ------- bebe9a0 Update 3.3-di-changes.rst
…tion (sroze) This PR was merged into the 4.1 branch. Discussion ---------- [Serializer] Fix the interface/abstract classes documentation See symfony/symfony#27451 Commits ------- af9726d Fix the interface/abstract classes documentation
This PR was merged into the 3.4 branch. Discussion ---------- Fix typo in Memcached adapter documentation PS: I sent this pull request against the `3.4` branch; is that OK? This issue first appeared in the `3.3` branch but that branch now only receives security fixes according to the maintenance roadmap. Commits ------- 2fe1f7e Fix typo in Memcached adapter documentation
The validator waits for a `config/validator` folder structure if we use the "file" approach, this structure must be respected.
…ikingone, javiereguiluz) This PR was submitted for the 4.1 branch but it was merged into the 4.0 branch instead (closes #9870). Discussion ---------- fix(Caution): Validator folder for YAML or XML format Hi, The validator waits for a `config/validator` folder structure if we use the "file" approach, this structure must be respected, it could be a great idea to informat that the structure is mandatory. Commits ------- 2f29f7a Reword bc83185 fix(Caution): Validator folder for YAML or XML format
If not using flex
Change 4.0 to 4.1
…atorz, javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Add composer require symfony/webpack-encore-pack If not using flex <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 22a061b Simplify fa74f26 Add composer require symfony/webpack-encore-pack
The link is missing from the fundamentals listing.
This PR was submitted for the 4.1 branch but it was merged into the 3.4 branch instead (closes #9879). Discussion ---------- Add link to configuration documentation The link is missing from the fundamentals listing. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- b4761a3 Add link to configuration documentation
The variable name `choice_value` did not contain the `$`.
I don't know if it's an error, but common practices is to define services in `app/config/services.yml`
This PR was submitted for the 4.1 branch but it was merged into the 2.8 branch instead (closes #9884). Discussion ---------- Fixed typo <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- ccb0e43 Fixed typo
This PR was merged into the 2.8 branch. Discussion ---------- Change code file location I don't know if it's a "mistake", but common practices is to define services in `app/config/services.yml` <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 9960f0c Fixed some wrong file paths 8e2ff4a Change code file location
This PR was merged into the 4.1 branch. Discussion ---------- Update upgrade_major.rst Change 4.0 to 4.1 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 6bab68e Update upgrade_major.rst
* 2.8: Fixed some wrong file paths Fixed typo Change code file location Reword the intro of a console article
* 3.4: Fixed some wrong file paths Change code file location Fix typo for variable name Add link to configuration documentation Add composer require symfony/webpack-encore-pack Reword the intro of a console article Fix typo in Memcached adapter documentation
* 4.0: Fixed some wrong file paths Change code file location Fix typo for variable name Add link to configuration documentation Add composer require symfony/webpack-encore-pack Reword the intro of a console article fix(Caution): Validator folder for YAML or XML format Fix typo in Memcached adapter documentation
* 4.1: Fixed some wrong file paths Change code file location Fix typo for variable name Add link to configuration documentation Update upgrade_major.rst Add composer require symfony/webpack-encore-pack Reword the intro of a console article fix(Caution): Validator folder for YAML or XML format Fix the interface/abstract classes documentation Fix typo in Memcached adapter documentation [#9507] add versionadded directive Revert "[#9507] remove csv processor, it was added in 4.1" [#9507] remove csv processor, it was added in 4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.