Skip to content

Make sub claim optional (and perhaps others?) #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
x-504 opened this issue Nov 26, 2021 · 2 comments · Fixed by #70
Closed

Make sub claim optional (and perhaps others?) #66

x-504 opened this issue Nov 26, 2021 · 2 comments · Fixed by #70

Comments

@x-504
Copy link

x-504 commented Nov 26, 2021

Hi guys, I am using your module and I'm wonder if we can made the sub claim optional?

This is the output in nginx error log when sending our JWT token:

2021/11/26 06:44:30 [error] 9#9: *14 the jwt does not contain a subject, client: 8.8.8.8, server: , request: "GET /secure-auth-header/ HTTP/1.1", host: "3.3.3.3:8000"
@amarbs
Copy link

amarbs commented Feb 24, 2022

@albertollamaso I would sugget to edit the summary of this issue to be more specific.
Can we make it: "sub field in claim is mandatory. Require to make it optional for other use-cases."

@JoshMcCullough JoshMcCullough changed the title Issue validating the JWT token Make sub claim optional (and perhaps others?) Jun 8, 2022
@JoshMcCullough JoshMcCullough linked a pull request Jun 8, 2022 that will close this issue
add option to not extract sub -- fixes #66 #70
Merged
@JoshMcCullough
Copy link
Contributor

@albertollamaso sorry for the delay -- PR #70 adds a new option which you may specifically disabled to turn off this log message:

auth_jwt_extract_sub off

JoshMcCullough added a commit that referenced this issue Jun 8, 2022
@JoshMcCullough
add option to not extract sub -- fixes #66 (#70)
aa024c5 
* add option to not extract sub

* move email variables into block where they are used

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add option to not extract sub -- fixes #66 TeslaGov/ngx-http-auth-jwt-module
3 participants
@JoshMcCullough @x-504 @amarbs