Skip to content

Support for MVC 5 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Nov 18, 2013 · 8 comments
Closed

Support for MVC 5 #11

ghost opened this issue Nov 18, 2013 · 8 comments

Comments

@ghost
Copy link

ghost commented Nov 18, 2013

As title says. Would be nice to have a DLL compiled with latest Framework version.

@robdmoore
Copy link
Member

In order to help me prioritise this - have you tried binding redirects (e.g. Add-BindingRedirect) with the current MVC4 package on NuGet (does that even allow you to install it with MVC5 or does the dependency version restrict it to 4?).

If it works then this is way lower priority for me, but it it doesn't work I'm happy to get something out quicker in the next few weeks...

@jesusgarza
Copy link

Add-BindingRedirect doesn't add the correct binding. But you can do it by hand and it does work:

      <dependentAssembly>
        <assemblyIdentity name="System.Web.Mvc" publicKeyToken="31bf3856ad364e35" culture="neutral" />
        <bindingRedirect oldVersion="0.0.0.0-4.0.0.0" newVersion="5.0.0.0" />
      </dependentAssembly>

@AlexArchive
Copy link
Contributor

I want to add that in the case that you are using an empty test project (as opposed to a scaffolded one) and you bring down the package - you will need to update the outdated ASP package dependencies by using the Update-Package command:

Update-Package -ProjectName ProjName.UnitTest

Failure to do this will subject you to a compile-time error as soon as you reference the testee project ;-p

@robdmoore
Copy link
Member

@byteblast as part of cleaning up the project I think we should add a .mvc5 and .mvc4 package. and make the non-.mvc* package have a dependency on the latest mvc package. Thoughts?

I've got an idea for how to easily make the .mvc* projects work in a future proof way too...

@AlexArchive
Copy link
Contributor

Sounds good mate.

On 5 September 2014 05:14, Robert Moore [email protected] wrote:

@byteblast https://github.com/ByteBlast as part of cleaning up the
project I think we should add a .mvc5 and .mvc4 package. and make the
non-.mvc* package have a dependency on the latest mvc package. Thoughts?

I've got an idea for how to easily make the .mvc* projects work in a
future proof way too...


Reply to this email directly or view it on GitHub
#11 (comment)
.

@AlexArchive
Copy link
Contributor

@Beton As per the latest pull request there is now support for MVC 5.

See the readme for more information.

@robdmoore
Copy link
Member

cc @mwhelan

@mwhelan
Copy link
Member

mwhelan commented Sep 21, 2014

Awesome! Thanks.

Sent from my iPad

On 21 Sep 2014, at 08:49, Robert Moore [email protected] wrote:

cc @mwhelan


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants