Skip to content

Trie Tree #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Trie Tree #133

merged 2 commits into from
Oct 11, 2018

Conversation

shubhamguptaji
Copy link
Contributor

No description provided.

Copy link
Member

@ms10398 ms10398 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add comments to the code

@ms10398 ms10398 merged commit f3f1536 into TheAlgorithms:master Oct 11, 2018
if (!root->isEndofWord)
return false;
root->isEndofWord = false;
for (int i = 0; i < 26; i++)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms10398 Can you please explain about these two lines?

for (int i = 0; i < 26; i++)
    return false;

As I understand, this loop will execute exactly once and will always return false and never true.
Can you fix that? If you can document the code, that would be much helpful. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants