Skip to content

#442 Update NUnit to 4.0.1 #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 11, 2024

Conversation

MarcosSimoneli
Copy link
Contributor

The NUnit package was updated to 4.0.1 and the corrections required by this update were made, the tests were executed successfully

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7f0d62) 94.89% compared to head (68dbc7a) 94.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   94.89%   94.94%   +0.04%     
==========================================
  Files         234      234              
  Lines        9843     9843              
  Branches     1382     1382              
==========================================
+ Hits         9341     9345       +4     
+ Misses        387      384       -3     
+ Partials      115      114       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak
Copy link
Member

siriak commented Feb 5, 2024

Please also check why tests fail, it has something to do with precision. Everything else looks good!

@siriak
Copy link
Member

siriak commented Feb 10, 2024

And please also resolve conflicts so that I could merge

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

@siriak siriak merged commit c9e2fa1 into TheAlgorithms:master Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants