Skip to content

added to Methods to the SinglyLinkedList (DeleteFirst, DeleteLast) #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 19, 2024
Merged

added to Methods to the SinglyLinkedList (DeleteFirst, DeleteLast) #450

merged 6 commits into from
Apr 19, 2024

Conversation

Ozzy-ZY
Copy link
Contributor

@Ozzy-ZY Ozzy-ZY commented Apr 16, 2024

added to Methods to the SinglyLinkedList (DeleteFirst, DeleteLast)

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

Ozzy-ZY and others added 3 commits April 15, 2024 17:24
@Ozzy-ZY
used a different way to split the block into 32 bits
5a2fba4 
I did this because the bitwise operations maybe not very readable 
specially for beginners
@Ozzy-ZY
Added 2 methods to the SinglyLinkedList (DeleteFirst, DeleteLast) and…
ffc6d2b 
… added new tests for them in the LinkedListTests.cs
@Ozzy-ZY
reverted the change of bitwise operations
ec02992
@Ozzy-ZY Ozzy-ZY requested a review from siriak as a code owner April 16, 2024 00:32
Ozzy-ZY
Ozzy-ZY commented Apr 16, 2024
View reviewed changes
siriak
siriak requested changes Apr 17, 2024
View reviewed changes
Ozzy-ZY
Ozzy-ZY commented Apr 17, 2024
View reviewed changes
Copy link
Contributor Author

@Ozzy-ZY Ozzy-ZY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied the suggestions provided by @siriak

@Ozzy-ZY Ozzy-ZY requested a review from siriak April 17, 2024 21:50
siriak
siriak reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check your indentation, but everything else looks good

@Ozzy-ZY Ozzy-ZY requested a review from siriak April 18, 2024 15:31
siriak
siriak approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit f32c043 into TheAlgorithms:master Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ozzy-ZY @siriak