Skip to content

Added Node generic classes #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 8, 2021
Merged

Added Node generic classes #2782

merged 6 commits into from
Nov 8, 2021

Conversation

aitorfi
Copy link
Contributor

@aitorfi aitorfi commented Oct 30, 2021 •
edited
Loading

Describe your change:

Added Node generic classes to be used directly or as superclasses for new implementations in order to avoid code repetition.

References

Related to issue #2774

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All functions and variable names follow Java naming conventions.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@aitorfi aitorfi marked this pull request as ready for review November 4, 2021 17:42
@aitorfi aitorfi changed the title Closes #2774 Added Node generic classes Added Node generic classes Nov 4, 2021
siriak
siriak approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit 7f3eb1b into TheAlgorithms:master Nov 8, 2021
@aitorfi aitorfi deleted the addGenericNodeClasses branch September 23, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aitorfi @siriak