refactor: redesign `LetterCombinationsOfPhoneNumber` #5221

samuelfac · 2024-06-12T11:29:29Z

Related to #5164

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Uncyclopedia or other similar explanations.
All new code is formatted with clang-format -i --style=file path/to/your/file.java

codecov-commenter · 2024-06-12T11:31:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.74%. Comparing base (31db1af) to head (87aff59).

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5221      +/-   ##
============================================
+ Coverage     38.73%   38.74%   +0.01%     
- Complexity     2384     2390       +6     
============================================
  Files           517      517              
  Lines         15391    15381      -10     
  Branches       2954     2957       +3     
============================================
- Hits           5961     5960       -1     
+ Misses         9143     9135       -8     
+ Partials        287      286       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…hub.com/samuelfac/Java into cleanup_LetterCombinationsOfPhoneNumber

src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java

src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

…oneNumberTest.java Co-authored-by: Piotr Idzik <[email protected]>

src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java

vil02

I allowed myself to push one commit into your branch: 910c814 I hope you don't mind.

The code looks good. I am just wondering if it makes sense to change the KEYPAD to a simple array. Let me know about your opinion.

src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java

src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java

src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java

src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java

Refactor

61e2a98

Samuel Facchinello added 6 commits June 12, 2024 13:32

fix clang

93252bf

fix clang

96bdb98

Merge branch 'cleanup_LetterCombinationsOfPhoneNumber' of https://git…

8fe553a

…hub.com/samuelfac/Java into cleanup_LetterCombinationsOfPhoneNumber

fix clang tests

bfb4d32

fix pattern

b228744

add test case null

b1a6124

samuelfac marked this pull request as ready for review June 12, 2024 12:15

samuelfac requested review from yanglbme, vil02 and BamaCharanChhandogi as code owners June 12, 2024 12:15

vil02 requested changes Jun 12, 2024

View reviewed changes

This was referenced Jun 12, 2024

refactor: redesign StringMatchFiniteAutomata #5222

Merged

[OTHER] Cleanup classes with very strange design #5164

Closed

Refactor: redesign ColumnarTranspositionCipher #5223

Closed

samuelfac and others added 10 commits June 12, 2024 17:14

Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPh…

667403b

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPh…

48f23e2

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPh…

e1a428c

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPh…

cc069a8

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPh…

fda621b

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPh…

d8ace83

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

Update src/test/java/com/thealgorithms/strings/LetterCombinationsOfPh…

b257d14

…oneNumberTest.java Co-authored-by: Piotr Idzik <[email protected]>

rename MAP_OF_CHARS to KEYPAD

575b5e1

fix clang

909acdb

remove main

1c100ef

samuelfac requested a review from vil02 June 12, 2024 15:24

vil02 reviewed Jun 12, 2024

View reviewed changes

src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java Outdated Show resolved Hide resolved

Samuel Facchinello and others added 2 commits June 12, 2024 17:50

add tests

97e26d3

feat: throw for wrong inputs

910c814

vil02 previously approved these changes Jun 12, 2024

View reviewed changes

src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java Outdated Show resolved Hide resolved

change keypad to list

06d49ce

samuelfac dismissed vil02’s stale review via 06d49ce June 13, 2024 08:21

vil02 requested changes Jun 13, 2024

View reviewed changes

Samuel Facchinello and others added 4 commits June 13, 2024 11:17

Merge branch 'master' into cleanup_LetterCombinationsOfPhoneNumber

349dedc

Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPh…

41c7007

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPh…

3ef428b

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPh…

d3f8c03

…oneNumber.java Co-authored-by: Piotr Idzik <[email protected]>

samuelfac requested a review from vil02 June 13, 2024 09:24

vil02 reviewed Jun 13, 2024

View reviewed changes

src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java Outdated Show resolved Hide resolved

vil02 force-pushed the cleanup_LetterCombinationsOfPhoneNumber branch from f07833b to d3f8c03 Compare June 13, 2024 09:40

vil02 reviewed Jun 13, 2024

View reviewed changes

src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java Outdated Show resolved Hide resolved

fix with number 1 (empty value), and add tests

24697f9

vil02 reviewed Jun 13, 2024

View reviewed changes

src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java Outdated Show resolved Hide resolved

style: avoid concatenation while populating KEYPAD

5b39d4b

vil02 reviewed Jun 13, 2024

View reviewed changes

src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java Outdated Show resolved Hide resolved

samuelfac and others added 3 commits June 13, 2024 19:27

Merge branch 'master' into cleanup_LetterCombinationsOfPhoneNumber

f83e55c

Merge branch 'master' into cleanup_LetterCombinationsOfPhoneNumber

aeb56a9

change to assertEquals

87aff59

vil02 approved these changes Jun 13, 2024

View reviewed changes

vil02 changed the title ~~Refactor: redesign LetterCombinationsOfPhoneNumber~~ refactor: redesign LetterCombinationsOfPhoneNumber Jun 13, 2024

vil02 merged commit 51fcc66 into TheAlgorithms:master Jun 13, 2024
5 checks passed

samuelfac deleted the cleanup_LetterCombinationsOfPhoneNumber branch June 13, 2024 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: redesign `LetterCombinationsOfPhoneNumber` #5221

refactor: redesign `LetterCombinationsOfPhoneNumber` #5221

Uh oh!

samuelfac commented Jun 12, 2024

Uh oh!

codecov-commenter commented Jun 12, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vil02 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

refactor: redesign LetterCombinationsOfPhoneNumber #5221

refactor: redesign LetterCombinationsOfPhoneNumber #5221

Uh oh!

Conversation

samuelfac commented Jun 12, 2024

Uh oh!

codecov-commenter commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vil02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

refactor: redesign `LetterCombinationsOfPhoneNumber` #5221

refactor: redesign `LetterCombinationsOfPhoneNumber` #5221

codecov-commenter commented Jun 12, 2024 •

edited

Loading