Skip to content

Added ADFGVXCipher.java #5631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 12, 2024
Merged

Conversation

bennybebo
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Uncyclopedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.72%. Comparing base (8722598) to head (f13913a).

Files with missing lines Patch % Lines
...n/java/com/thealgorithms/ciphers/ADFGVXCipher.java 92.59% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5631      +/-   ##
============================================
+ Coverage     63.61%   63.72%   +0.11%     
- Complexity     4111     4130      +19     
============================================
  Files           577      578       +1     
  Lines         16143    16197      +54     
  Branches       3102     3117      +15     
============================================
+ Hits          10269    10322      +53     
  Misses         5452     5452              
- Partials        422      423       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennybebo bennybebo marked this pull request as ready for review October 7, 2024 17:24
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you please add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit f8397bf into TheAlgorithms:master Oct 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants