-
Notifications
You must be signed in to change notification settings - Fork 20k
Add Elliptic Curve Cryptography Algorithm #5700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both time complexity and space complexity are O(n)
Implementation of ECC encryption algorithm and unit test with java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5700 +/- ##
============================================
+ Coverage 62.77% 62.92% +0.14%
- Complexity 4025 4033 +8
============================================
Files 565 566 +1
Lines 15939 16012 +73
Branches 3076 3081 +5
============================================
+ Hits 10006 10075 +69
- Misses 5521 5523 +2
- Partials 412 414 +2 ☔ View full report in Codecov by Sentry. |
siriak
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I’ve added the Elliptic Curve Cryptography (ECC) algorithm to the project. The ECC class handles key generation, encryption, and decryption using elliptic curve operations. I also included classes for defining elliptic curves and points on those curves, which are essential for performing ECC computations.
Elliptic Curve Cryptography offers several advantages, including stronger security with smaller key sizes compared to other cryptographic systems like RSA. This makes ECC highly efficient in terms of computational performance, memory usage, and bandwidth, which is especially beneficial for mobile devices and environments with limited resources.
Additionally, I’ve written several unit tests to verify the encryption and decryption processes, ensure randomness in the ciphertexts, and check functionality with known values. This implementation aims to provide a simple but effective introduction to ECC for cryptographic purposes.