Skip to content

maths-polynomial_evalutation #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2019
Merged

maths-polynomial_evalutation #1214

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d20c959
maths-polynomial_evalutation
msk4862 Sep 30, 2019
e84b7bd
added doctest and removed redundancy
msk4862 Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions maths/polynomial_evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
def evaluate_poly(poly, x):
"""
Objective: Computes the polynomial function for a given value x.
Returns that value.
Input Prams:
poly: tuple of numbers - value of cofficients
x: value for x in f(x)
Return: value of f(x)
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a doctest:

    >>> evaluate_poly((0.0, 0.0, 5.0, 9.3, 7.0), 10)
    79800.0

Then makes sure it passes locally with: python3 -m doctest -v maths/polynomial_evaluation.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss thanks for the suggestion!
will do the changes.

i = 0
res = 0
for c in poly:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for i, c in enumerate(poly): # then delete lines 14 and 10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the whole function can be a one-liner: return sum(c * x ** i for i, c in enumerate(poly))

res += c * (x ** i)
i += 1
return res


if __name__ == "__main__":
"""
Example: poly = (0.0, 0.0, 5.0, 9.3, 7.0) # f(x) = 7.0x^4 + 9.3x^3 + 5.0x^2
x = -13
print (evaluate_poly(poly, x)) # f(-13) = 7.0(-13)^4 + 9.3(-13)^3 + 5.0(-13)^2 = 180339.9
"""
poly = (0.0, 0.0, 5.0, 9.3, 7.0)
x = 10
print(evaluate_poly(poly, x))