Skip to content

update non-recursive factorial #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2019
Merged

update non-recursive factorial #1351

merged 1 commit into from
Oct 18, 2019

Conversation

yuriimchg
Copy link
Contributor

  • wrapped the algorithm with function;
  • add docstring;
  • renamed variables / constants.

@cclauss
Copy link
Member

cclauss commented Oct 18, 2019

https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings does not encourage overindenting docstrings.

@cclauss cclauss merged commit 870eebf into TheAlgorithms:master Oct 18, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@yuriimchg @stokhos
rewrite the algorithm from scratch (TheAlgorithms#1351)
c7a1ada
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@DanishSheikh1999 DanishSheikh1999 DanishSheikh1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuriimchg @cclauss @DanishSheikh1999