Updated lower and upper

[realDuYuanChao]

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Uncyclopedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[l3str4nge]

I am not sure but in my opinion this change causes a decrease of algorithm speed. Is comparing strings is not faster than comparing ints - in ord() case? @cclauss Your knowledge is need here! :)

[cclauss]

Anyone up for creating a timeit benchmark?

[realDuYuanChao]

I test it using timeit. It prove new version is faster.

def lower_faster(word: str = "HelloWorld I LOVE PYTHON") -> str:
    return "".join(
        chr(ord(char) + 32) if 'A' <= char <= 'Z' else char for char in word
    )


def lower_slower(word: str = "HelloWorld I LOVE PYTHON") -> str:
    return "".join(
        chr(ord(char) + 32) if 65 <= ord(char) <= 90 else char for char in word
    )


def benchmark() -> None:
    import timeit
    print(timeit.timeit("lower_slower()", setup="from __main__ import lower_slower", number=1000))
    print(timeit.timeit("lower_faster()", setup="from __main__ import lower_faster", number=1000))


if __name__ == "__main__":

    benchmark()

output:

0.005637370000000003
0.005095732000000002

[cclauss]

Please remove number=1000 and re-benchmark.

[realDuYuanChao]

Please remove number=1000 and re-benchmark.

like this below ?

print(timeit.timeit("lower_slower()", setup="from __main__ import lower_slower"))

[realDuYuanChao]

After I removed number=1000.

def lower_faster(word: str = "HelloWorld I LOVE PYTHON") -> str:
    return "".join(
        chr(ord(char) + 32) if 'A' <= char <= 'Z' else char for char in word
    )


def lower_slower(word: str = "HelloWorld I LOVE PYTHON") -> str:
    return "".join(
        chr(ord(char) + 32) if 65 <= ord(char) <= 90 else char for char in word
    )


def benchmark() -> None:
    import timeit
    print(timeit.timeit("lower_slower()", setup="from __main__ import lower_slower"))
    print(timeit.timeit("lower_faster()", setup="from __main__ import lower_faster"))


if __name__ == "__main__":

    benchmark()

output

4.604586689
4.297654392999999

[cclauss]

It is always nice to have a benchmark to verify performance.

[realDuYuanChao]

You are my Python teacher. I learn so much from you. Thanks a lot 👍