Skip to content

Adding bmi_conversion.py #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Adding bmi_conversion.py #3587

wants to merge 2 commits into from

Conversation

Snimer
Copy link
Contributor

@Snimer Snimer commented Oct 20, 2020

Describe your change:

Adding bmi_conversion.py
It converts Mass and Height into Body Mass Index.
It contains two functions. One to convert BMI from Metric units and one from US units.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Uncyclopedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

l3str4nge
l3str4nge requested changes Oct 21, 2020
View reviewed changes
@l3str4nge l3str4nge added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 21, 2020
@Snimer Snimer requested a review from l3str4nge October 22, 2020 03:30
l3str4nge
l3str4nge requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@l3str4nge l3str4nge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add following doctest to us_units_bmi:

>>> us_units_bmi(130, 0)
  WHAT RESULT WE SHOULD EXPECT?

@Snimer
Copy link
Contributor Author

Snimer commented Oct 25, 2020

Please add following doctest to us_units_bmi:

>>> us_units_bmi(130, 0)
  WHAT RESULT WE SHOULD EXPECT?

@mateuszz0000
I am closing this pull request because I deleted the branch from where the file was.
So, I am made a different pull request. Please review this one-
#3727

@Snimer Snimer closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge requested changes

@kbakdev kbakdev kbakdev approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snimer @l3str4nge @kbakdev