Skip to content

Enter logic for Quadratic hashing #6498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Enter logic for Quadratic hashing #6498

wants to merge 4 commits into from

Conversation

silam
Copy link
Contributor

@silam silam commented Oct 1, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Uncyclopedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Oct 1, 2022
CaedenPH
CaedenPH requested changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shebang must be on the very first line

@silam silam requested a review from CaedenPH October 2, 2022 13:53
CaedenPH
CaedenPH approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 2, 2022
Closed
14 tasks
@silam
Copy link
Contributor Author

silam commented Oct 3, 2022

How do I know what I did that I got label: tests are failing

@silam silam requested a review from CaedenPH October 3, 2022 11:21
@cclauss cclauss closed this Oct 31, 2022
@cclauss cclauss reopened this Oct 31, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 31, 2022
@cclauss
Copy link
Member

cclauss commented Oct 31, 2022

Lines are > 88 characters per line.

@cclauss cclauss closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH Awaiting requested review from CaedenPH

Assignees
No one assigned
Labels
enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silam @cclauss @CaedenPH