Skip to content

Project Euler Problems in Hackerrank solved! #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

junthbasnet
Copy link
Contributor

No description provided.

@junthbasnet junthbasnet changed the title Project Euler Problems in Hackerrank solved... Project Euler Problems in Hackerrank solved! May 30, 2019
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put these in an appropriate folder. Also if the algorithm is already there, you may improve or provide alternative implementation. Thanks.!

@poyea poyea added the on hold label May 31, 2019
@junthbasnet
Copy link
Contributor Author

I added it to the appropriate folder.

@junthbasnet
Copy link
Contributor Author

Quick Sort with the middle element as the pivot is added

Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider making these changes! Thank you.

@@ -0,0 +1,19 @@
# Author : Junth Basnet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a project_euler folder in root. Please put this into one of the folders inside.

@@ -0,0 +1,25 @@
#Author : Junth Basnet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already exists in maths. Please delete this.

@@ -0,0 +1,35 @@
# Author : Junth Basnet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This can be merged.

@github-actions
Copy link

github-actions bot commented Dec 1, 2019

Stale pull request message

@github-actions github-actions bot closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants