Skip to content

circular_linked_list.py #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

circular_linked_list.py #873

wants to merge 3 commits into from

Conversation

TheIncredibleHarsh
Copy link

@TheIncredibleHarsh TheIncredibleHarsh commented Jun 4, 2019

A circular linked list where the last node points to the first node. I don't know why it is missing and I think it should be here. Helps in traversing the list in circular order and we don't have to start traversing from head every time

Circular linked list is a linked list where last node is connected to the first node in the list. This can be used in traversals where we have to access a node before the current by access in a circular way.
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename needs to end in “.py”

Also, please remove the semicolons (;) as this is Python, not JavaScript.

@TheIncredibleHarsh TheIncredibleHarsh changed the title circular_linked_list circular_linked_list.py Jun 4, 2019
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 4 spaces to indent. Other than that LGTM. Thanks.

@TheIncredibleHarsh
Copy link
Author

Why is the LGTM check failing? It gives error on some other file, I'm sorry but I have never worked with it before

@cclauss
Copy link
Member

cclauss commented Jun 6, 2019

LGTM tests are failing because of the Python syntax error in #425

@TheIncredibleHarsh TheIncredibleHarsh deleted the patch-1 branch June 8, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants