add ons in string directory - Boyer_Moore_Search #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's "Boyer" Moore Search. If I'm right, please let me change it. |
|
Yes, it's my bad. I will edit it. Thanks.
…On Tue, Jul 2, 2019 at 1:59 PM Erfan Alimohammadi ***@***.***> wrote:
I think it's "Boyer" Moore Search. If I'm right, please let me change it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#933?email_source=notifications&email_token=AHKYK4ZQ5VRGSOGWN73HUTDP5MGWLA5CNFSM4H4RQRW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZAPYCA#issuecomment-507575304>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHKYK46ADOPY2BJO33NUBDDP5MGWLANCNFSM4H4RQRWQ>
.
|
Dharni0607
changed the title
Erfaniaa
reviewed
Jul 2, 2019
strings/Boyer_Moore_Search.py
Outdated
| m=length of pattern string | ||
| """ | ||
|
|
||
| class BayerMooreSearch: |
There was a problem hiding this comment.
Please change the dictation mistake in the class name.
strings/Boyer_Moore_Search.py
Outdated
| return currentPos + i | ||
| return -1 | ||
|
|
||
| def badCharacterHeuristic(self): |
There was a problem hiding this comment.
Please use snake_case for all methods.
Like: bad_character_heuristic
strings/Boyer_Moore_Search.py
Outdated
| def badCharacterHeuristic(self): | ||
| positions = [] | ||
| for i in range(self.textLen - self.patLen + 1): | ||
| misMatchIndex = self.misMatchInText(i) |
There was a problem hiding this comment.
Use snake_case: mismatch_index
Try to use it in all variable names.
strings/Boyer_Moore_Search.py
Outdated
| return -1 | ||
|
|
||
|
|
||
| """ following functions tries to find the mis-matched character's index in text from last, |
There was a problem hiding this comment.
Place docstrings after the "def" line.
Explain the parameters and the return value separately.
Please Google "Python docstrings conventions".
https://www.datacamp.com/community/tutorials/docstrings-python#second-head
strings/Boyer_Moore_Search.py
Outdated
| pattern = "ABC" | ||
| bms = BayerMooreSearch(text, pattern) | ||
| positions = bms.badCharacterHeuristic() | ||
| if(len(positions) == 0): |
strings/Boyer_Moore_Search.py
Outdated
| print("No match found") | ||
| else: | ||
| print("Pattern found in following positions: ") | ||
| print(positions) |
There was a problem hiding this comment.
I ran your code and the algorithm seems to work fine.
Dharni0607
force-pushed
the
issue#697
branch
4 times, most recently
from
3377842 to
62d0413
Compare
Erfaniaa
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#697, I have added Boyer Moore search function(bad character heuristic). Please review and let me know if any changes are required. Thanks. ;)