Skip to content

Introduce error types #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024

Conversation

salmanmkc
Copy link
Contributor

Pull Request Template

Description

Just added some extra tests and used typiing for some errors. Might do some more soon.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@salmanmkc salmanmkc requested review from imp2002 and vil02 as code owners April 30, 2024 17:56
@salmanmkc salmanmkc marked this pull request as draft April 30, 2024 17:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 94.77%. Comparing base (20c92d7) to head (4be9f49).

Files Patch % Lines
src/data_structures/queue.rs 80.00% 3 Missing ⚠️
src/data_structures/range_minimum_query.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage   94.78%   94.77%   -0.02%     
==========================================
  Files         297      297              
  Lines       22149    22182      +33     
==========================================
+ Hits        20994    21023      +29     
- Misses       1155     1159       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salmanmkc
Copy link
Contributor Author

in draft mode, just doing this for fun and will get back but got a bunch of things I need to run to first

@salmanmkc salmanmkc marked this pull request as ready for review May 1, 2024 20:18
@vil02 vil02 changed the title typing errors, extra tests Introduce error types May 7, 2024
@vil02 vil02 merged commit 1020ea2 into TheAlgorithms:master May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants