Skip to content

chore: run build each Thursday #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 16, 2024

Pull Request Template

Description

In order to avoid new problems after a clippy update, I suggest to run the build cyclically for example each Thursday.

Related to #718, but I wanted to keep its scope as small as possible, to have it merged as quick as possible.

The CI will pass with having #718.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@vil02 vil02 requested a review from imp2002 as a code owner May 16, 2024 15:12
@vil02 vil02 mentioned this pull request May 16, 2024
7 tasks
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.78%. Comparing base (1020ea2) to head (406ddd7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #719   +/-   ##
=======================================
  Coverage   94.77%   94.78%           
=======================================
  Files         298      298           
  Lines       22194    22210   +16     
=======================================
+ Hits        21035    21052   +17     
+ Misses       1159     1158    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 28be0a3 into TheAlgorithms:master May 16, 2024
3 of 4 checks passed
@vil02 vil02 deleted the add_cron_to_build branch May 16, 2024 16:45
sozelfist pushed a commit to sozelfist/Rust that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants