Skip to content

style: include unnecessary_wraps #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jul 6, 2024

Pull Request Template

Description

This PR removes the unnecessary_wraps from the list of suppressed lints. Although it is marked as MaybeIncorrect (buy sill of pedantic), I think in these cases it is justified. If we will find some some false positive, we can remove this check.

Continuation of #743.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@vil02 vil02 marked this pull request as ready for review July 6, 2024 19:59
@vil02 vil02 requested a review from imp2002 as a code owner July 6, 2024 19:59
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (aa8c458) to head (699af2d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
- Coverage   95.05%   95.05%   -0.01%     
==========================================
  Files         306      306              
  Lines       22736    22733       -3     
==========================================
- Hits        21612    21609       -3     
  Misses       1124     1124              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 requested a review from siriak July 6, 2024 19:59
@siriak siriak merged commit 5f0eab8 into TheAlgorithms:master Jul 6, 2024
4 checks passed
@vil02 vil02 deleted the include_unnecessary_wraps branch July 6, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants