perf: Optimize BTree search using binary search #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit optimizes the search function in the BTree implementation by replacing the linear search with a binary search algorithm. This change significantly improves the search performance, especially for large trees. Implementation details: - Modified the `search` method in the `BTree` struct - Replaced the while loop with `binary_search` method on the `keys` vector Complexity analysis: - Previous implementation: O(n) per node, where n is the number of keys - New implementation: O(log n) per node Benchmark results: - Environment: MacOS 14.5, Apple M1 Pro, 32 GB RAM - Dataset: 1,000,000 random integers for insertion - Search: 1,000,000 searches for the key 500,000 - Before: - Insertion: 3.002587333s - Search: 2.334683584s - After: - Insertion: 2.998482583s - Search: 288.659458ms Note: Insertion time remains largely unchanged, as expected. All existing tests pass with the new implementation. Benchmark code is not included in this commit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
=======================================
Coverage 95.07% 95.08%
=======================================
Files 309 309
Lines 22781 22788 +7
=======================================
+ Hits 21660 21667 +7
Misses 1121 1121 ☔ View full report in Codecov by Sentry. |
vil02
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Thanks for spotting that. I added few tests: b772765.
By the way: would you like to spend some more time with this class? Code like BTree::new(0) or BTree::new(1) should not work in my opinion. Feel free to open a new PR fixing that.
Of course! I’ll work on fixing that issue and submit a PR soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request optimizes the search function in the BTree implementation by replacing the linear search with a binary search algorithm. This change significantly improves the search performance, especially for large trees, without altering the existing functionality.
The optimization is achieved by modifying the
searchmethod in theBTreestruct to use thebinary_searchmethod on thekeysvector instead of a while loop. This change reduces the time complexity of searching within a node from O(n) to O(log n), where n is the number of keys in the node.Type of change
Implementation Details
The main changes are in the
searchmethod of theBTreestruct:binary_searchmethod on thekeysvector.Benchmark Results
Environment: MacOS 14.5, Apple M1 Pro, 32 GB RAM
Dataset: 1,000,000 random integers for insertion, 1,000,000 searches for the key 500,000
Before optimization:
After optimization:
Note: Insertion time remains largely unchanged, as expected.
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.CONTRIBUTING.mdand my code follows its guidelines.All existing tests pass with the new implementation. No new tests were added as the existing ones adequately cover the modified functionality.