Added dewpoint getter to WundergroundClient #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Squix78, you did not respond up to now. I still hope you to accept my little change. If there are any reasons, this change may not be acceptable, please don't hesitate to tell me. Quite sure, you are very busy, but it really would be helpful for CavAir... Thanks in advance, Yours |
|
Hi Count023 Sorry that I didn't integrate your change yet, after maintaining the upstream OLED library I totally forgot to check pull requests on this library... I will do this now. Thanks a lot for your contribution! |
|
Hi Squix78, thanks for adding ... ;) Yours, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Squix78,
a friend of mine (@Taquma) asked for the already by W.Underground provided dewpoint information also to be available in your nice library. He is using it for his third version of CavAir ...
I would be pleased you to review and hopefully accept this pull request ;)
Yours count023