Skip to content

Adding support for aasvg graphics. #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

Adding support for aasvg graphics. #216

merged 2 commits into from
Mar 11, 2025

Conversation

eckelmeckel
Copy link
Contributor

@eckelmeckel eckelmeckel commented Mar 11, 2025 •
edited
Loading

Adding support for aasvg graphics/diagrams.

Example:

```aasvg
+--------+    .-------.     +--------+
| Server +-->+ Message +--->+ Client |
+--------+    '-------'     +--------+
```

Further: some minor syntax and grammar/text fixes.

Fixes #215 and fixes #207 (PR #208 can be considered obsolete, I think).

@eckelmeckel
Adding support for aasvg graphics.
32e1fff 
Adding support for aasvg graphics/diagrams.

Example:

```aasvg
+--------+    .-------.     +--------+
| Server +-->+ Message +--->+ Client |
+--------+    '-------'     +--------+
```

Further: some minor syntax and grammar/text fixes.

Signed-off-by: Michael Eckel <[email protected]>
@eckelmeckel eckelmeckel mentioned this pull request Mar 11, 2025
Closed
chrisfenner
chrisfenner approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool. One nit: could you add an example of this to the guide.tcg as a mini-test and so that people can see how to use it and how it looks?

@eckelmeckel
Copy link
Contributor Author

This is super cool. One nit: could you add an example of this to the guide.tcg as a mini-test and so that people can see how to use it and how it looks?

Oh, thanks, good point. Done.

@chrisfenner
Copy link
Member

We got this error again: ERROR: failed to solve: failed to push ghcr.io/trustedcomputinggroup/pandoc_test: unexpected status from POST request to https://ghcr.io/v2/trustedcomputinggroup/pandoc_test/blobs/uploads/: 403 Forbidden

I don't think it's related to the change, so I'll merge it anyway.

@chrisfenner chrisfenner merged commit a4f5265 into TrustedComputingGroup:main Mar 11, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisfenner chrisfenner chrisfenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ASCII Art SVG (aasvg) diagrams SVG conversion issues with draw.io
2 participants
@eckelmeckel @chrisfenner