Added test and implementation for LongRange #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tynamix
requested changes
May 18, 2020
There was a problem hiding this comment.
Hey! Thank you for your pull request. I know. I'm a bit lazy in maintaining this repository. But i have a lil child in the best age of getting her first teeth... Its pain! Anyways... I appreciate your participation a lot.
One remark... Could you please move the LongRange to an own folder called "Long". The plugins are organized by the types they are dedicated for. So in the Integer folder should be just plugins for the integer type...
weitzhandler
force-pushed
the
feature/long-range
branch
from
d37e413 to
29c966a
Compare
|
Congrats on the baby! A long is also an integer :) Anyway, requested changes have been applied. |
Tynamix
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
If this PR gets merged, will add ULong etc.
Maybe even a static method
Range.Get<T>(T? min, T? max)whereTis any numeric value int/uint/byte/double etc.