Skip to content

fix for highlighting #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2015
Merged

fix for highlighting #671

merged 1 commit into from
Oct 19, 2015

Conversation

stepancar
Copy link
Contributor

fix for #666

@stepancar
Copy link
Contributor Author

@basarat , i just go to babel then to json, then to cson.
As i see issue fixed.
But needs test.
My question - how to test changes of grammar? Do you have any standard how to atom should highlight tsx?

@stepancar stepancar changed the title fix for highliting fix for highlight Oct 19, 2015
@stepancar stepancar changed the title fix for highlight fix for highlighting Oct 19, 2015
@basarat
Copy link
Member

basarat commented Oct 19, 2015

Sure ... why not 🌹

Note : if something breaks in the next few days I will undo this and tag you in :)

basarat added a commit that referenced this pull request Oct 19, 2015
@basarat
Merge pull request #671 from stepancar/patch-1
917b688 
fix for highlighting
@basarat basarat merged commit 917b688 into TypeStrong:master Oct 19, 2015
@basarat
Copy link
Member

basarat commented Oct 19, 2015

closes #666

@basarat
Copy link
Member

basarat commented Oct 19, 2015

Released https://github.com/TypeStrong/atom-typescript/releases/tag/v7.4.3 🌹

@basarat
Copy link
Member

basarat commented Oct 19, 2015

Note to myself : similar PR in atom-react : orktes/atom-react#105

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
category:grammar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepancar @basarat