use externalTranspiler before doing diffs for status #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create new function `getRawOutputPostExternal` with same interface as getRawOutput except that it returns a <Promise<ts.EmitOutput> instead of a ts.EmitOutput. This function calls getRawOutut, then passes the result through `runExternalTranspiler` so that babel, if configured, is applied. Call/use this new function in `getOutputJsStatus`. Net result: people using babel are not constantly being told their JS is Outdated. Closes TypeStrong#737
| if (output.emitSkipped) { | ||
| if (output.outputFiles && output.outputFiles.length === 1) { | ||
| if (output.outputFiles[0].text === building.Not_In_Context) { | ||
| return getRawOutputPostExternal(project, query.filePath) |
There was a problem hiding this comment.
Think it should only be called if the project config says that an external transpiler needs to be used 🌹 or am I misreading
There was a problem hiding this comment.
runExternalTranspiler (which is called by getRawOutputPostExternal) is kind of a misnomer. It's a no-op if an external transpiler isn't configured to run. Ref: https://github.com/laurelnaiad/atom-typescript/blob/iss737/lib/main/lang/modules/building.ts#L168
basarat
added a commit
that referenced
this pull request
Nov 26, 2015
use externalTranspiler before doing diffs for status
|
Cheers. Will publish with next release 🌹 |
|
Reversing this commit. Just because I'm lazy, its 9pm on a Friday :) and this causes #765 🌹 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new function
getRawOutputPostExternalwith same interfaceas getRawOutput except that it returns a
<Promise<ts.EmitOutput>instead of a ts.EmitOutput.
This function calls getRawOutut, then passes the result through
runExternalTranspilerso that babel, if configured, is applied.Call/use this new function in
getOutputJsStatus.Net result: people using babel are not constantly being told their
JS is Outdated.