Skip to content

#726 adds show-type command for type info at cursor #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2016
Merged

#726 adds show-type command for type info at cursor #970

merged 1 commit into from
Jun 6, 2016

Conversation

dylanscott
Copy link
Contributor

This PR adds a show-type command that displays type information at the cursor. The overlay looks like this:
screen shot 2016-06-05 at 10 22 35 pm

Some notes:

  • The type information overlay is dismissed when the cursor position changes, the escape key is pressed, or when the editor the overlay is in loses focus.
  • I did not merge this code path with the one that displays type information on hover, mostly out of laziness.
  • This is my first change on an Atom package so any improvement suggestions would be very welcome.

@dylanscott dylanscott mentioned this pull request Jun 6, 2016
Closed
@basarat
Copy link
Member

basarat commented Jun 6, 2016

Looks good to me and I don't want to block you. Thanks! ❤️

If anybody reports a bug, I'll just revert and ping you 🌹

@basarat basarat merged commit 9226e10 into TypeStrong:master Jun 6, 2016
@basarat
Copy link
Member

basarat commented Jun 6, 2016

Released with 8.11.0 🌹 Thanks again ❤️

@dylanscott
Copy link
Contributor Author

Awesome, thanks for the quick turnaround!

@clarencecastillo clarencecastillo mentioned this pull request Dec 25, 2017
Closed
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanscott @basarat