fix(TU-2535): secure dependencies, update axios #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thr44
force-pushed
the
fix/TU-2535/update-axios
branch
from
5c652a0 to
cc686b5
Compare
Thr44
commented
Nov 15, 2023
| @@ -21,7 +21,7 @@ test('request pass correct headers', async () => { | |||
| }, | |||
| }) | |||
| expect(axios.history.get[0].url).toBe(`${API_BASE_URL}/forms`) | |||
| expect(axios.history.get[0].headers).toEqual({ | |||
| expect({ ...axios.history.get[0].headers }).toEqual({ | |||
There was a problem hiding this comment.
test was complaining because object is not a AxiosHeader
mumpo
approved these changes
Nov 15, 2023
|
🎉 This PR is included in version 1.15.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get 100% on secure dependencies we need to update axios, as it has a high severity vulnerability:
https://app.snyk.io/org/developer-relations-hax/project/0a05a01a-e24b-4b7b-af6e-509cbd9088c2
to do so, I also had to bump jest