fix(NOJIRA-123): fix return type in themes list #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathio
changed the title
|
Thank you for updating types 💪 I have rebased your PR on latest Let's merge this. |
mathio
approved these changes
Oct 4, 2023
|
🎉 This PR is included in version 1.8.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typeform.API.Themesnamespace with aListinterface that matches the returned type from the GET/themesendpoint.themes.list()method return type fromPromise<Typeform.Theme[]>to the newPromise<Typeform.API.Themes.List>.Motivation and Context
When using the
js-api-clientlibrary with Typescript, the return type fromthemes.list()does not match the payload returned by the endpoint, making it quite difficult to work with.Testing
I'm not sure how to test this yet, sorry.
Backward Compatibility
These changes will break backward compatibility.
Screenshots
None.