Skip to content

Compare changes across branches, commits, tags, and more below. #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 4, 2020
Merged

Compare changes across branches, commits, tags, and more below. #511

merged 4 commits into from
Aug 4, 2020

Conversation

GulajavaMinistudio
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Zara Cooper and others added 4 commits August 3, 2020 12:52
@alxhub
revert: docs(core): correct SomeService to SomeComponent (#38325)
87baa06 
This reverts commit b4449e3.

The example given from the previous change was for a component selector and not a provider selector.

This change fixes it.

Fixes #38323.

PR Close #38325
@alexeagle @alxhub
build: cleanup .bazelrc file to no longer set unused flags (#38124)
e49b053 
This option is no longer needed in Bazel and will be an error in the future

PR Close #38124
@JiaLiPassion @alxhub
feat(core): rename async to waitForAsync to avoid confusing (#37583)
8f07429 
@angular/core/testing provide `async` test utility, but the name `async` is
confusing with the javascript keyword `async`. And in some test case, if you
want to use both the `async` from `@angular/core/testing` and `async/await`,
you may have to write the code like this.

```typescript
it('test async operations', async(async() => {
  const result = await asyncMethod();
  expect(result).toEqual('expected');
}));
```

So in this PR, the `async` is renamed to `waitForAsync` and also deprecate `async`.

PR Close #37583
@JiaLiPassion @alxhub
feat(core): update reference and doc to change async to waitAsync. (
8fbf40b 
#37583)

The last commit change `async` to `waitForAsync`.
This commit update all usages in the code and also update aio doc.

PR Close #37583
@GulajavaMinistudio GulajavaMinistudio merged commit daacb00 into TypescriptID:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GulajavaMinistudio @alexeagle @JiaLiPassion